[2661] Fix BroadcastReceiver ANR at ScreenOffTrigger #2732
+64
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
reviewed
Dec 19, 2024
| analysisClient.newJob(JobContext(ScreenOffTrigger::class)) | ||
| currentJob = job | ||
| analysisExecutor.execute { | ||
| analysisExecutor.execute { |
There was a problem hiding this comment.
If analysisExecutor.execute runs the task quickly enough, there's a chance that we might dump the heap & freeze the VM before the process has had a chance to report back to system_server, right?
Looks to me like if we want to avoid that, we need to execute with a delay instead"?
There was a problem hiding this comment.
Good point. I just updated it with a delayed executor. So far seems to be working as well and ANR is no longer reproducible internally
Add a delayedScheduledExecutorService
Adding delay Add a delayedScheduledExecutorService Fix BroadcastReceiver ANR
…om/FranAguilera/leakcanary into franjam/fix_broadcast_receiver_anr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2661
Issue
BroadcastReceiver#onReceive runs by default on the main thread. If onReceive doesn't complete in a timely manner, the system will report an Application Not Responding
We've seen instances of this occurring frequently on internal builds
Solution
NOTE: Kudos to @pyricau for the guidance on adding a delay.
Let the broadcast receiver complete immediately and schedule the executor with an initial delay to avoid issues with the broadcast receiver not completing
Verification
Verified that the the ANR no longer occurs and reporting still completes without issues on one of our main apps (internal release build)
This was heavily tested on internal builds